Add quick-cryptic crossword type #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-nowak
force-pushed
the
an/quick-cryptic
branch
from
0582b95
to
2138d96
Compare
jonathonherbert
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Seems reasonable. Who the heck is DIAN 😀
Point of interest – what maps QUICK_CRYPTIC to quick-cryptic? It doesn't look like it's scrooge fezziwig.
|
yep, both those questions had me scratching my head, but since I was getting the answer I wanted I didn't question it too much -- now have gone back and traced it out and it looks like it's this thrift enum decoder in the json module https://github.com/guardian/content-api-models/blob/main/json/src/main/scala/com/gu/contentapi/json/CirceEncoders.scala#L20-L23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the upcoming Quick-Cryptic crossword type to the CAPI models. Required to have the crossword type correctly parsed from ES and returned in the Concierge response.
Tested as a local snapshot and confirmed working end-to-end through local Crosswordv2/Composer/CAPI
Before:
After: