Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some trust_return_value_nullability's for gtk #67

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Add some trust_return_value_nullability's for gtk #67

merged 1 commit into from
Nov 21, 2020

Conversation

sophie-h
Copy link
Contributor

No description provided.

@sdroege
Copy link
Member

sdroege commented Nov 21, 2020

@sophie-h You might want to create an issue like gtk-rs/gtk3-rs#163 also here in gtk4-rs to keep track of this :)

sdroege
sdroege reviewed Nov 21, 2020
View reviewed changes
gtk4/Gir.toml Show resolved Hide resolved
sdroege
sdroege reviewed Nov 21, 2020
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise, thanks for taking care of this :)

bilelmoussaoui
bilelmoussaoui reviewed Nov 21, 2020
View reviewed changes
generator.py Outdated Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui merged commit e86ddd4 into gtk-rs:master Nov 21, 2020
@bilelmoussaoui
Copy link
Member

Thanks!

@sdroege sdroege mentioned this pull request Nov 21, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilelmoussaoui bilelmoussaoui bilelmoussaoui left review comments

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophie-h @sdroege @bilelmoussaoui