improve: derive more #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng JIANG <alex_cj96@foxmail.com>
|
derive let mut p = Personalization::default();
p.add_to(...)which eventually fixes #79 |
|
@gsquire hi could you have a look, thanks |
|
Hey, @GopherJ. I am currently moving out of state so it'll be a little while before I can review. I'm sorry for the delay! |
gsquire
requested changes
Jan 1, 2021
|
|
||
| [dev-dependencies] | ||
| tokio = { version = "0.3", features = ["full"] } | ||
|
|
||
| [features] | ||
| default = ["native-tls", "blocking"] | ||
| default = ["native-tls", "async"] |
There was a problem hiding this comment.
I think we should leave the blocking option as default and let people opt into using async.
Also, is there any way to undo the formatting that changed here?
|
Closing, see #79 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cheng JIANG alex_cj96@foxmail.com
close: #79