Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Swift 5.5 #1585

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Drop support for Swift 5.5 #1585

merged 2 commits into from
Apr 12, 2023

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Apr 11, 2023 •
edited
Loading

Motivation:

Now that 5.8 has been released we can drop support for Swift 5.5.

Modifications:

  • Update CI jobs
  • Remove conditional branches which are no longer supported
  • Remove Package@swift-5.5.swift
  • Use Sendable in place of GRPCSendable
  • Update docs

Result:

Swift 5.6 is the lowest supported Swift version

@glbrntt
Drop support for Swift 5.5
aff076d 
Motivation:

Now that 5.8 has been released we can drop support for Swift 5.5.

Modifications:

- Update CI jobs
- Remove conditional branches which are no longer supported
- Update docs

Result:

Swift 5.6 is the lowest supported Swift version
@glbrntt glbrntt marked this pull request as ready for review April 11, 2023 13:00
@glbrntt glbrntt added the semver-minor ↑ Requires a SemVer Minor version change label Apr 11, 2023
@glbrntt glbrntt mentioned this pull request Apr 11, 2023
Closed
@glbrntt glbrntt requested a review from FranzBusch April 11, 2023 13:59
@glbrntt glbrntt requested a review from FranzBusch April 12, 2023 09:33
FranzBusch
FranzBusch approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glbrntt glbrntt enabled auto-merge (squash) April 12, 2023 09:36
@glbrntt glbrntt disabled auto-merge April 12, 2023 09:53
@glbrntt glbrntt merged commit d2d60e6 into grpc:main Apr 12, 2023
@glbrntt glbrntt deleted the gb-drop-swift-55 branch April 12, 2023 09:55
WendellXY pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
@glbrntt @WendellXY
Drop support for Swift 5.5 (grpc#1585)
35b0928 
Motivation:

Now that 5.8 has been released we can drop support for Swift 5.5.

Modifications:

- Update CI jobs
- Remove conditional branches which are no longer supported
- Update docs

Result:

Swift 5.6 is the lowest supported Swift version
pinlin168 pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
@glbrntt @pinlin168
Drop support for Swift 5.5 (grpc#1585)
7531503 
Motivation:

Now that 5.8 has been released we can drop support for Swift 5.5.

Modifications:

- Update CI jobs
- Remove conditional branches which are no longer supported
- Update docs

Result:

Swift 5.6 is the lowest supported Swift version
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees
No one assigned
Labels
semver-minor ↑ Requires a SemVer Minor version change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @FranzBusch