Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import paths to SPM Plugin #1568

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

samisuteria
Copy link
Contributor

Added an optional parameter to the config file so users can configure import paths for protoc.

Useful in a mono repo where the proto file is not in the target directory and requires imports that are defined relative to the proto.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: samisuteria / name: Sami Suteria (68094dc)

Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@glbrntt glbrntt enabled auto-merge (squash) February 14, 2023 09:04
@glbrntt glbrntt added the semver-patch • Requires a SemVer Patch version change label Feb 14, 2023
@glbrntt glbrntt merged commit 3e4c8e3 into grpc:main Feb 14, 2023
WendellXY pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
pinlin168 pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch • Requires a SemVer Patch version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants