Add regression test capturing need for withCause
call
#460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I noticed when writing #456 is that with the new branch capturing Status exceptions, the existing regression test that I modified to throw a non-status exception is no longer sufficient to ensure the stack trace is available to the interceptor. Concretely,
Status.fromThrowable(exception)
will always haveexception
as the cause of the status so long asexception
is not a Status exception and has no Status exception in its causal chain.This PR adds a test covering that case; without the extra
withCause
call this test will fail.