-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kt_jvm_proto_helper as individual rule. #396
Merged
Merged
Commits on Jul 5, 2023
-
Add kt_jvm_proto_helper as individual rule.
This allows the BUILD file to have separate java proto and kt proto rules in case there is a mix of java and proto projects in the same repo, and there are stricter requirement to the output (e.g. leaner dependency chains, smaller binaries for pure-java outputs etc.). This also bypasses an issue in the other rules where the kt_jvm_*_library would compile the whole dependency chain to kotlin, and if the bazel repo is large with many proto dependencies, an can easily end up caching all of these when containing the same classes. If only some of these are refreshed / synced on changes you can easily end up with an IDE claiming your new fields still dont' exist, or removed classes are still there etc.
Configuration menu - View commit details
-
Copy full SHA for 8343c18 - Browse repository at this point
Copy the full SHA 8343c18View commit details
Commits on Jul 17, 2023
-
Which makes btth kr_proto and kt_grpc helper functions.
Configuration menu - View commit details
-
Copy full SHA for f3aadf5 - Browse repository at this point
Copy the full SHA f3aadf5View commit details
Commits on Aug 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5c6c35c - Browse repository at this point
Copy the full SHA 5c6c35cView commit details
Commits on Sep 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 656f83b - Browse repository at this point
Copy the full SHA 656f83bView commit details
Commits on Sep 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bc7e4ed - Browse repository at this point
Copy the full SHA bc7e4edView commit details
Commits on Nov 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0752d7e - Browse repository at this point
Copy the full SHA 0752d7eView commit details
Commits on Dec 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0c1a59c - Browse repository at this point
Copy the full SHA 0c1a59cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 165b622 - Browse repository at this point
Copy the full SHA 165b622View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0997e0 - Browse repository at this point
Copy the full SHA c0997e0View commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8bccc2c - Browse repository at this point
Copy the full SHA 8bccc2cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.