Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded concurrency things #360

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Remove unneeded concurrency things #360

merged 5 commits into from
Dec 1, 2023

Conversation

taer
Copy link
Contributor

@taer taer commented Sep 28, 2022

The mutex and atomicBolean aren't needed in this context.

The mutex is only contained in a local variable in sequential code. It isn't shared w/ any other threads. The same with the atomic bolean.

Both of these constructs are inside the launched co-routine, and aren't shared outside. Therefore they can't help control any other shared access.

@ghost
Copy link

ghost commented Sep 28, 2022

The gist of this is I'm looking into why we have some nasty corner cases. This isn't it, but it's a slight optimization that could be made wrt the flow handling

@taer
Copy link
Contributor Author

taer commented Mar 10, 2023

@lowasser Just checking in to see if this project is still alive or if you have any questions/concerns on this?

@taer
Copy link
Contributor Author

taer commented Sep 13, 2023

@jamesward Thoughts on this?

@jamesward
Copy link
Collaborator

We will need @lowasser to review this.

@taer
Copy link
Contributor Author

taer commented Sep 14, 2023

Ok. The idea here is none of these mutexes or atomicBooleans are ever used concurrently they're very sequential in their nature, so having the lock there doesn't accomplish anything.

@lowasser
Copy link
Collaborator

lowasser commented Dec 1, 2023

This does look safe to me.

@jamesward jamesward removed the request for review from lowasser December 1, 2023 06:05
@jamesward jamesward merged commit 98bebab into grpc:master Dec 1, 2023
8 of 9 checks passed
@ejona86 ejona86 mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants