Defer writing headers until the first message stanza is sent #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gentle ping. Any updates on this? 😀 |
lowasser
reviewed
Sep 30, 2021
| @@ -241,8 +239,14 @@ object ServerCalls { | |||
| val rpcScope = CoroutineScope(context) | |||
| rpcScope.async { | |||
| val mutex = Mutex() | |||
| val headersSent = AtomicBoolean(false) // enforces only sending headers once | |||
| val failure = runCatching { | |||
| implementation(requests).collect { | |||
There was a problem hiding this comment.
I think this breaks if the responses are empty. Could we at least also do the check after collection is complete?
There was a problem hiding this comment.
Good catch, thanks. Added that and tests to catch that case.
lowasser
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #272 (see the issue for more background).
This change makes
grpc-kotlinmore consistent with the behaviour ofgrpc-javaandgrpc-go, which don't write the HTTP/2 headers until the first response frame is sent. Current behaviour sends an empty header frame immediately, which can force downstream proxies (namely Envoy) to commit the response, which disables retry behaviour.