Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the dep tree for stub-lite - fixes #117 #199

Merged
merged 6 commits into from
Nov 2, 2020
Merged

fixes the dep tree for stub-lite - fixes #117 #199

merged 6 commits into from
Nov 2, 2020

Conversation

jamesward
Copy link
Collaborator

No description provided.

stub-lite/build.gradle Outdated Show resolved Hide resolved
@jamesward
Copy link
Collaborator Author

Once we release this, we can switch the samples to use it.

@jamesward
Copy link
Collaborator Author

Outstanding question... is api the right scope in stub and stub-lite for the transitive grpc deps?

@jamesward
Copy link
Collaborator Author

From what I can tell, the api scope is correct because the stub / stub-lite and their dependencies are needed at compile time in projects that depend on them.

@jamesward jamesward marked this pull request as ready for review October 29, 2020 19:39
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@bshaffer bshaffer merged commit e73585c into master Nov 2, 2020
@bshaffer bshaffer deleted the stub-dep branch November 2, 2020 17:34
@bshaffer bshaffer mentioned this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants