Skip to content

Commit

Permalink
switch examples to correct stub-lite usage
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesward committed Oct 29, 2020
1 parent c4523f6 commit 40782eb
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 23 deletions.
2 changes: 1 addition & 1 deletion examples/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {

// todo: move to subprojects, but how?
ext["grpcVersion"] = "1.32.1"
ext["grpcKotlinVersion"] = "0.2.0" // CURRENT_GRPC_KOTLIN_VERSION
ext["grpcKotlinVersion"] = "0.2.1" // CURRENT_GRPC_KOTLIN_VERSION
ext["protobufVersion"] = "3.13.0"

allprojects {
Expand Down
11 changes: 1 addition & 10 deletions examples/stub-android/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,7 @@ dependencies {
implementation("javax.annotation:javax.annotation-api:1.3.2")

api("com.google.protobuf:protobuf-javalite:${rootProject.ext["protobufVersion"]}")
api("io.grpc:grpc-protobuf-lite:${rootProject.ext["grpcVersion"]}")

// todo: I think we should be able to just include this:
// api("io.grpc:grpc-kotlin-stub-lite:${rootProject.ext["grpcKotlinVersion"]}")
// but it doesn't pull transitives correctly

api("io.grpc:grpc-stub:${rootProject.ext["grpcVersion"]}")
api("io.grpc:grpc-kotlin-stub:${rootProject.ext["grpcKotlinVersion"]}") {
exclude("io.grpc", "grpc-protobuf")
}
api("io.grpc:grpc-kotlin-stub-lite:${rootProject.ext["grpcKotlinVersion"]}")
}

android {
Expand Down
11 changes: 1 addition & 10 deletions examples/stub-lite/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,7 @@ dependencies {
implementation("javax.annotation:javax.annotation-api:1.3.2")

api("com.google.protobuf:protobuf-javalite:${rootProject.ext["protobufVersion"]}")
api("io.grpc:grpc-protobuf-lite:${rootProject.ext["grpcVersion"]}")

// todo: I think we should be able to just include this:
// api("io.grpc:grpc-kotlin-stub-lite:${rootProject.ext["grpcKotlinVersion"]}")
// but it doesn't pull transitives correctly

api("io.grpc:grpc-stub:${rootProject.ext["grpcVersion"]}")
api("io.grpc:grpc-kotlin-stub:${rootProject.ext["grpcKotlinVersion"]}") {
exclude("io.grpc", "grpc-protobuf")
}
api("io.grpc:grpc-kotlin-stub-lite:${rootProject.ext["grpcKotlinVersion"]}")
}

java {
Expand Down
2 changes: 0 additions & 2 deletions examples/stub/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ dependencies {
implementation("javax.annotation:javax.annotation-api:1.3.2")

api("com.google.protobuf:protobuf-java-util:${rootProject.ext["protobufVersion"]}")
api("io.grpc:grpc-stub:${rootProject.ext["grpcVersion"]}")
api("io.grpc:grpc-protobuf:${rootProject.ext["grpcVersion"]}")
api("io.grpc:grpc-kotlin-stub:${rootProject.ext["grpcKotlinVersion"]}")
}

Expand Down

0 comments on commit 40782eb

Please sign in to comment.