Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterresolver/e2e_test: Avoid making DNS requests #7561

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Aug 26, 2024

The test is presently making a real DNS request for a non existing domain bad.ip.v4.address. This makes the test non-hermitic and could potentially be the cause of the test flaking. This change makes the test use a fake resolver to avoid making DNS requests.

Related issue: #7354

RELEASE NOTES: None

@arjan-bal arjan-bal added this to the 1.67 Release milestone Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (b45fc41) to head (ecbaa50).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7561      +/-   ##
==========================================
- Coverage   82.07%   81.86%   -0.22%     
==========================================
  Files         360      361       +1     
  Lines       27533    27825     +292     
==========================================
+ Hits        22599    22779     +180     
- Misses       3759     3848      +89     
- Partials     1175     1198      +23     
Files with missing lines Coverage Δ
resolver/manual/manual.go 100.00% <100.00%> (ø)

... and 50 files with indirect coverage changes

@easwars easwars assigned arjan-bal and unassigned easwars Aug 26, 2024
@arjan-bal arjan-bal assigned easwars and unassigned arjan-bal Aug 26, 2024
@arjan-bal arjan-bal requested a review from easwars August 26, 2024 22:47
@easwars easwars assigned arjan-bal and unassigned easwars Aug 29, 2024
@arjan-bal arjan-bal merged commit 55d820d into grpc:master Aug 29, 2024
14 checks passed
@arjan-bal arjan-bal deleted the fix-aggregated-cluster-test branch August 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants