Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #7356 to v1.66.x branch #7546

Merged
merged 2 commits into from
Aug 23, 2024
Merged

cherry-pick #7356 to v1.66.x branch #7546

merged 2 commits into from
Aug 23, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 21, 2024

RELEASE NOTES:

  • tbd

@dfawley dfawley added the Type: Performance Performance improvements (CPU, network, memory, etc) label Aug 21, 2024
@dfawley dfawley added this to the 1.66 Release milestone Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 86.68516% with 96 lines in your changes missing coverage. Please review.

Project coverage is 81.86%. Comparing base (f857020) to head (979b464).
Report is 1 commits behind head on v1.66.x.

Files Patch % Lines
rpc_util.go 79.77% 15 Missing and 3 partials ⚠️
mem/buffers.go 82.75% 13 Missing and 2 partials ⚠️
internal/leakcheck/leakcheck.go 86.04% 8 Missing and 4 partials ⚠️
encoding/proto/proto_v2.go 68.96% 5 Missing and 4 partials ⚠️
internal/transport/transport.go 91.91% 4 Missing and 4 partials ⚠️
server.go 78.78% 7 Missing ⚠️
stream.go 91.02% 4 Missing and 3 partials ⚠️
codec.go 82.60% 3 Missing and 1 partial ⚠️
encoding/encoding_v2.go 55.55% 2 Missing and 2 partials ⚠️
experimental/experimental.go 0.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.66.x    #7546      +/-   ##
===========================================
+ Coverage    81.82%   81.86%   +0.04%     
===========================================
  Files          360      362       +2     
  Lines        27542    27865     +323     
===========================================
+ Hits         22537    22813     +276     
- Misses        3802     3845      +43     
- Partials      1203     1207       +4     
Files Coverage Δ
internal/transport/grpchttp2/http2bridge.go 98.31% <100.00%> (ø)
internal/transport/handler_server.go 89.69% <100.00%> (+0.36%) ⬆️
internal/transport/http2_client.go 91.96% <100.00%> (+0.05%) ⬆️
internal/transport/http2_server.go 90.69% <100.00%> (-0.29%) ⬇️
mem/buffer_pool.go 100.00% <100.00%> (+9.43%) ⬆️
preloader.go 60.00% <100.00%> (+15.55%) ⬆️
stats/stats.go 71.42% <ø> (ø)
internal/transport/controlbuf.go 88.74% <96.66%> (-2.46%) ⬇️
dialoptions.go 89.02% <50.00%> (-0.93%) ⬇️
internal/grpctest/grpctest.go 73.52% <71.42%> (+3.52%) ⬆️
... and 11 more

... and 18 files with indirect coverage changes

@dfawley dfawley merged commit 62baa5f into grpc:v1.66.x Aug 23, 2024
13 of 14 checks passed
@dfawley dfawley deleted the encoding branch August 23, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Performance Performance improvements (CPU, network, memory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants