-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolver: update Resolver.Scheme() docstring to mention requirement of lowercase scheme names #6014
Conversation
Also recommend Scheme() to return no uppercase letters, as RFC3986 requires parsing to convert the scheme to lowercase Fixes grpc#6011.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than the panic in the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
resolver_test.go
Outdated
@@ -88,10 +89,15 @@ func (s) TestResolverCaseSensitivity(t *testing.T) { | |||
// globally-registered resolver. Since it is "dns" instead of passthrough, | |||
// we can validate by checking for an address that has been resolved | |||
// (i.e. is not "localhost:port"). | |||
cc, err = Dial(target, WithContextDialer(customDialer), WithResolvers(res), WithTransportCredentials(insecure.NewCredentials())) | |||
|
|||
// WithDisableServiceConfig disables TXT lookups, which can hang for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
oh wait, seems like the tests are still failing with a similar pattern |
all tests are green now |
PTAL after the changes as discussed earlier today. |
Also test the case-senstiveness of the checks.
Fixes #6011.
RELEASE NOTES: