test: reduce end2end log spam #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gerrit code review: https://go-review.googlesource.com/19451 (at git rev 4e9bdfe) |
|
|
||
| var testLogOutput = &lockingWriter{w: os.Stderr} | ||
|
|
||
| func awaitLogOutput(t *testing.T, maxWait time.Duration, phrase string) { |
There was a problem hiding this comment.
Oh, yeah, I changed my mind about something earlier. Removed.
I have grander plans for all this logging stuff, but this is a baby step.
|
LGTM. Leveled logging would be pretty helpful here. |
|
Gerrit code review: https://go-review.googlesource.com/19451 (at git rev fa64708) |
Closed
|
Gerrit code review: https://go-review.googlesource.com/19451 (at git rev 35e8ba4) |
|
Rebased. No new changes. |
|
Gerrit code review: https://go-review.googlesource.com/19451 (at git rev f8861d0) |
|
Gerrit code review: https://go-review.googlesource.com/19451 (at git rev 303da9d) |
Filter expected log output by default, unless a flag is provided, or a test fails. This makes it possible to see unexpected things. Having noisy tests makes it too easy to miss actual problems.
|
Gerrit code review: https://go-review.googlesource.com/19451 (at git rev ffa8131) |
iamqizhao
added a commit
that referenced
this pull request
Feb 16, 2016
test: reduce end2end log spam
dfawley
pushed a commit
to dfawley/grpc-go
that referenced
this pull request
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter expected log output by default, unless a flag is provided, or a
test fails.
This makes it possible to see unexpected things. Having noisy tests
makes it too easy to miss actual problems.