Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: avoid an unnecessary allocation per-RPC for OK status #2920

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

dzbarsky
Copy link
Contributor

We have a stream-heavy workloud and this accounts for 2% of our allocations.

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@dzbarsky
Copy link
Contributor Author

signed it

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the optimization.

@dfawley dfawley added the Type: Performance Performance improvements (CPU, network, memory, etc) label Jul 22, 2019
@dfawley dfawley added this to the 1.23 Release milestone Jul 22, 2019
@dfawley dfawley changed the title Avoid creating new status on every rpc server: avoid an unnecessary allocation per-RPC for OK status Jul 22, 2019
@dfawley dfawley merged commit 04c71b7 into grpc:master Jul 22, 2019
@dzbarsky dzbarsky deleted the statusok branch July 22, 2019 17:48
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Performance Performance improvements (CPU, network, memory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants