resolver/dns: exponential retry when getting empty address list #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Jul 6, 2018
resolver/dns/dns_resolver.go
Outdated
| @@ -66,7 +67,7 @@ func NewBuilder() resolver.Builder { | |||
| } | |||
|
|
|||
| type dnsBuilder struct { | |||
| // frequency of polling the DNS server. | |||
| // minimum frequency of polling the DNS server. | |||
There was a problem hiding this comment.
I think frequency is minimum, interval is maximum.
There was a problem hiding this comment.
Yes, you're right. The variable is not actually the frequency, it's the interval, hence my confusion.
I also think we should rename the variable to something to indicate it's a limit now, e.g. "maxDelay" or "minFreq".
resolver/dns/dns_resolver.go
Outdated
| d.retryCount++ | ||
| d.t.Reset(d.backoff.Backoff(d.retryCount)) | ||
| } else { | ||
| if d.retryCount != 0 { |
There was a problem hiding this comment.
The "if" here is unnecessary and is worse for performance (CPUs hate conditional branches far more than stores).
dfawley
approved these changes
Jul 12, 2018
dfawley
approved these changes
Jul 13, 2018
menghanl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1795