Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in EachFilter in Xcode 14.3 #89

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

NSHaoSong
Copy link
Contributor

@NSHaoSong NSHaoSong commented Apr 5, 2023

Fix the following warning in Xcode 14.3 (14E222b):

Sources/EachFilter.swift:46:65: Tuple conversion from '(key: String, value: MustacheBox)' to '(key: String, box: MustacheBox)' mismatches labels

Screenshot 2023-04-05 at 7 54 29 AM

Related changes in apple/swift:

// If we had a label mismatch, emit a warning. This is something we
// shouldn't permit, as it's more permissive than what a conversion would
// allow. Ideally we'd turn this into an error in Swift 6 mode.

Fix the following warning:

```
Sources/EachFilter.swift:46:65: Tuple conversion from '(key: String, value: MustacheBox)' to '(key: String, box: MustacheBox)' mismatches labels
```
@NSHaoSong NSHaoSong changed the title Fix warning in EachFilter Fix warning in EachFilter in Xcode 14.3 Apr 19, 2023
Copy link
Collaborator

@fumito-ito fumito-ito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NSHaoSong ! Sorry for delay.

@fumito-ito fumito-ito merged commit 5d80f1b into groue:master Jun 29, 2023
@NSHaoSong NSHaoSong deleted the fix-warning-each-filter branch June 30, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants