Add background-selected-subtle and background-selected-subtle-hover
#396
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.Recording.2024-05-13.at.4.06.39.PM.mov |
taysea
approved these changes
May 13, 2024
taysea
changed the title
background-selected-subtle and background-selected-subtle-hover
jcfilben
reviewed
May 14, 2024
There was a problem hiding this comment.
It looks like these colors don't meet the contrast ratio requirements
https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast.html
@jcfilben I double checked this and they seem fine-- can you clarify where you were seeing a failure? 
|
|
Converting to draft, I misunderstood Jessica's comment but she noted that the selected box itself does not meet color contrast with the unselected boxes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds background for select and select hover to allow for easier color contrast accessibility in Select component.
What testing has been done on this PR?
on the site
Any background context you want to provide?
#390
What are the relevant issues?
#390
Screenshots (if appropriate)
Is this change backward compatible or could it be a breaking change for the official HPE theme?
change
How should this PR be communicated in the release notes?