Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolbar kind to data object #374

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add toolbar kind to data object #374

merged 1 commit into from
Dec 12, 2023

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Dec 12, 2023

What does this PR do?

Adds kind: toolbar for Data controls to align with functionality introduced by: grommet/grommet#7025

What testing has been done on this PR?

Tested in Grommet PR.

Any background context you want to provide?

What are the relevant issues?

Closes #373

Screenshots (if appropriate)

Is this change backward compatible or could it be a breaking change for the official HPE theme?

How should this PR be communicated in the release notes?

Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcfilben jcfilben merged commit 1adec6f into master Dec 12, 2023
3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data.button.kind to HPE theme
3 participants