replace glyphs in material-nf which are overwritten arabic chars #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NerdFonts has one big issue. They overwrite code points which are reserved for chinese and arabic letters (range 0xf500-0xfd46). While overwriting chinese letters is bad, they are LTR glyphs and print "normally". `net_loopback` and `update` used to be symbols that usually map to arabic letters which make pango print those strings RTL. I tried to fix this with the LTR marker 0x200e in greshake#1206 but it failed. This PR replaces the symbols with similar ones that don't map to the arabic charset. nerd-font issue: ryanoasis/nerd-fonts#365 fixes greshake#1206
|
Thanks! This is the best approach so far since it has been two years and #365 still has not been addressed. |
|
I assume he means ryanoasis/nerd-fonts#365 |
MaxVerevkin
pushed a commit
to MaxVerevkin/swaystatus
that referenced
this pull request
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NerdFonts has one big issue. They overwrite code points which are
reserved for chinese and arabic letters (range 0xf500-0xfd46).
While overwriting chinese letters is bad, they are LTR glyphs and print
"normally".
net_loopbackandupdateused to be symbols that usually mapto arabic letters which make pango print those strings RTL. I
tried to fix this with the LTR marker 0x200e in #1206 but it failed.
This PR replaces the symbols with similar ones that don't map to
the arabic charset.
nerd-font issue: ryanoasis/nerd-fonts#365
fixes #1206