Fix byte-compiler warnings of calls to deprecated functions or missing declarations. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change from deprecated cl library to non-deprecated cl-lib.
- Retain Emacs 24 compatibility. If Emacs 25 had been the requirement could have used defvar-local. - Add empty defvar forward declaration of variable to prevent byte-compiler warnings. - Add declare-function forms where needed, including in places where the byte compiler does not track declarations when a defun is inside a code branch. - Unused arguments of hooks have names that begin with underscore to prevent byte compiler warning.
Extend elisp parser regexp to understand cl-*
|
@gregsexton Thanks for this nice package! I hope that you will be able to merge this work. |
…ghter for origami-mode with delight.
|
@gregsexton ping. Anything else needed here? |
This was referenced Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my repo I have also merge the work from others that fixed some of the warnings (but not all). And the addition of cl- forms for Emacs Lisp.