Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): make all CLI options available in config #445

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

gregberge
Copy link
Owner

@gregberge gregberge commented Apr 27, 2020

Related #431, #437

Summary

All CLI options can now be defined in .svgrrc.

Test plan

@vercel
Copy link

vercel bot commented Apr 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/2bsu6ipzy
✅ Preview: https://svgr-git-cli-options-in-config.gregberge.now.sh

@vercel vercel bot requested a deployment to Preview April 27, 2020 20:15 Abandoned
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #445 into master will not change coverage.
The diff coverage is 94.73%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   86.60%   86.60%           
=======================================
  Files          31       31           
  Lines         560      560           
  Branches      155      155           
=======================================
  Hits          485      485           
  Misses         60       60           
  Partials       15       15           
Impacted Files Coverage Δ
packages/webpack/src/index.js 95.45% <66.66%> (ø)
...ckages/babel-plugin-add-jsx-attribute/src/index.js 100.00% <100.00%> (ø)
...ges/babel-plugin-remove-jsx-attribute/src/index.js 100.00% <100.00%> (ø)
...ckages/babel-plugin-svg-dynamic-title/src/index.js 100.00% <100.00%> (ø)
...ckages/babel-plugin-svg-em-dimensions/src/index.js 93.75% <100.00%> (ø)
...bel-plugin-transform-react-native-svg/src/index.js 97.72% <100.00%> (ø)
packages/babel-preset/src/index.js 93.54% <100.00%> (ø)
packages/core/src/config.js 100.00% <100.00%> (ø)
packages/hast-util-to-babel-ast/src/all.js 100.00% <100.00%> (ø)
...ckages/hast-util-to-babel-ast/src/getAttributes.js 90.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b59cd...8c6f7b5. Read the comment docs.

@gregberge gregberge merged commit 6179cd9 into master Apr 27, 2020
@gregberge gregberge deleted the cli-options-in-config branch April 27, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant