make --out-dir generate correct dir path with absolute path #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 85.57% 85.57%
=======================================
Files 24 24
Lines 520 520
Branches 103 103
=======================================
Hits 445 445
Misses 67 67
Partials 8 8Continue to review full report at Codecov.
|
gregberge
reviewed
Oct 15, 2018
packages/cli/src/dirCommand.js
Outdated
| @@ -50,7 +50,10 @@ async function dirCommand( | |||
| if (!isCompilable(relative)) return false | |||
| relative = rename(relative, ext, filenameCase) | |||
|
|
|||
| const dest = path.join(program.outDir, relative) | |||
| const dest = program.outDir.startsWith('/') | |||
There was a problem hiding this comment.
Why not always using path.resolve()?
There was a problem hiding this comment.
You're right. I've removed the condition and always use path.resolve() here.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Input:
svgr --ext=tsx --out-dir=/Users/rrli/Downloads "/Users/rrli/Downloads/Group6.svg",Expected: "/Users/rrli/Download/Group6.svg"
Actual: "/Users/rrli/Downloads/Users/rrli/Downloads/Group6.tsx"
Test plan