Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript config only available in CLI #437

Closed
wants to merge 1 commit into from
Closed

fix: typescript config only available in CLI #437

wants to merge 1 commit into from

Conversation

michielmetcake
Copy link

The option typescript: is not working in the svgr config.

Summary

This is a update in the docs to explain the API Override to be available in CLI only.

How to reproduce

In package JSON:

Non working example:

"script": {"build:svg": "svgr icons icons},
 "svgr": {"typescript": true }

Working example:

"script": {"build:svg": "svgr icons icons --typescript},

@vercel
Copy link

vercel bot commented Apr 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/81gxrr1vs
✅ Preview: https://svgr-git-fork-michielmetcake-feature-typescript-flag.gregberge.now.sh

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #437 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files          31       31           
  Lines         557      557           
  Branches      153      153           
=======================================
  Hits          482      482           
  Misses         60       60           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30bb85...39d1f84. Read the comment docs.

@gregberge
Copy link
Owner

It is not true. TypeScript option is required in CLI to correctly generate index and extension. So it is a bug in fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants