Change: Add base-image-label as input, control image-tags by base-image-label. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0urself
reviewed
Sep 23, 2024
Co-authored-by: Jaspar Stach <jaspar.stach@greenbone.net>
Co-authored-by: Jaspar Stach <jaspar.stach@greenbone.net>
robert-schardt
changed the title
y0urself
reviewed
Sep 24, 2024
Move image-tags to docker-metadata action
y0urself
reviewed
Sep 24, 2024
y0urself
reviewed
Sep 24, 2024
|
y0urself
reviewed
Sep 25, 2024
Co-authored-by: Jaspar Stach <jaspar.stach@greenbone.net>
robert-schardt
changed the title
pascalholthaus
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
image-typebase-image-label as input for container-build-push-2nd-gen workflow.The
image-typebase-image-label is an enum with the following possible values:According to the set value the image-tags are enabled.
Why
We wanted to merge the container.yml and push.yml workflows in gvm-libs.
The legacy workflow builds additional gvm-libs containers with oldstable and testing tags.
To represent this logic we need to parametrize the container-build-push-2nd-gen workflow somehow.
References
https://jira.greenbone.net/browse/DEVOPS-1230
This is the PR requiring the changes: greenbone/gvm-libs#838
Test is here:
https://github.com/greenbone/pipeline-experiments/actions/workflows/test-container-build-push-2nd-gen.yml