Change: Make installing nvt feed sync script optional #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new Python based greenbone-feed-sync script is available at https://github.com/greenbone/greenbone-feed-sync/ and should be used instead of the shell based greenbone-nvt-sync script shipped with openvas-scanner. The new script is easier to maintain, to adapt and can be released independently. Therefore make installing the shell optional and don't install it by default anymore.
y0urself
approved these changes
Apr 19, 2023
This was referenced Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
A new Python based greenbone-feed-sync script is available at https://github.com/greenbone/greenbone-feed-sync/ and should be used instead of the shell based greenbone-nvt-sync script shipped with openvas-scanner. The new script is easier to maintain, to adapt and can be released independently.
Therefore make installing the shell optional and don't install it by default anymore. To still install the script
cmake -DINSTALL_OLD_SYNC_SCRIPTS=ONcan be used.Why
Users should switch to the new sync script as soon as possible. Therefore don't install it anymore in the next release by default.
References
Replaces #1337
DEVOPS-516