Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: GMP doc: be more accurate about user SOURCES #2211

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mattmundell
Copy link
Contributor

What

In GMP CREATE_USER and MODIFY_USER, clarify that SOURCES may contain at most one SOURCE.

Why

Clearer.

References

SOURCES were restricted to a single SOURCE when user management was moved into the db in aacc589.

Example

Single source is OK:

$ o m m '<modify_user><name>test7</name><password>test</password><sources><source>file</source></sources></modify_user>'
<modify_user_response status="200" status_text="OK" />

Multiple sources is an error:

$ o m m '<modify_user><name>test7</name><password>test</password><sources><source>file</source><source>ldap_connect</source></sources></modify_user>'
<modify_user_response status="400" status_text="Error in SOURCES" />

@mattmundell mattmundell requested a review from a team as a code owner May 31, 2024 00:16
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@a-h-abdelsalam a-h-abdelsalam merged commit 60af6e4 into main Jun 14, 2024
11 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the gmp-doc-clarify-sources branch June 14, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants