Fix: Fix false changed results in delta reports #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple results with the same VT, host, port, and severity but with different descriptions, delta results are now chosen so they match the original result with the same description if one exists. Without this, the identical results would falsely be shwon as changed.
Conventional Commits Report
🚀 Conventional commits found. |
jhelmold
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When there are multiple results with the same VT, host, port, and severity but with different descriptions, delta results are now chosen so they match the original result with the same description if one exists.
Why
Without this, the identical results would falsely be shown as changed.
References
GEA-320