Fix handling of SSH keys in modify_credential #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the private key header and footer are not recognized by truncate_private_key, the original key is now used as intended instead of reverting to the old private key. Also, the truncate_private_key function will now work with "-----BEGIN OPENSSH PRIVATE KEY-----" and the corresponding footer.
jhelmold
approved these changes
May 4, 2022
timopollmeier
added
the
backport-to-stable
timopollmeier
added a commit
that referenced
this pull request
May 11, 2022
Merge pull request #1822 from greenbone/mergify/bp/stable/pr-1818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
If the private key header and footer are not recognized by
truncate_private_key, the original key is now used as intended instead
of reverting to the old private key.
Also, the truncate_private_key function will now work with
"-----BEGIN OPENSSH PRIVATE KEY-----" and the corresponding footer.
Why:
This fixes not being able to modify credentials with SSH keys using
"-----BEGIN OPENSSH PRIVATE KEY-----" (AP-1990).
How did you test it:
Checklist: