Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible-docker-entrypoint #1764

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Flexible-docker-entrypoint #1764

merged 4 commits into from
Dec 13, 2021

Conversation

bjoernricks
Copy link
Contributor

What:

Use gosu to run gvmd as dedicated gvmd user.

Why:

Alllow to become root for debugging purposes.

> docker run -it --rm greenbone/gvmd:unstable id                
uid=1001(gvmd) gid=1001(gvmd) groups=1001(gvmd)

> docker run -it --rm --entrypoint='' greenbone/gvmd:unstable id 
uid=0(root) gid=0(root) groups=0(root)

How did you test it:

Checklist:

  • Tests
  • PR merge commit message adjusted

@bjoernricks
Ensure /var/lib/gvm is available in docker container
8cc2a82 
Just ensure that /var/lib/gvm exists before trying to change its
permissions.
@bjoernricks
Install gosu tool to allow changing user easily
c30ccf4
@bjoernricks
Use an entrypoint script to switch to gvmd user
40ca72e 
Instead of changing the user in the dockerfile add an entrypoint script
that uses gosu to switch to the dedicated gvmd user before starting the
command. This allows becoming root in the container by resetting the
entrypoint.
@bjoernricks bjoernricks requested review from a team as code owners December 10, 2021 13:06
@bjoernricks bjoernricks added backport-to-oldstable This pull request will be backported to the oldstable branch backport-to-stable This pull request will be backported to the stable branch labels Dec 10, 2021
@bjoernricks bjoernricks merged commit 32079f0 into main Dec 13, 2021
@bjoernricks bjoernricks deleted the flexible-docker-entrypoint branch December 13, 2021 16:09
This was referenced Dec 13, 2021
Merged
Merged
y0urself added a commit that referenced this pull request Dec 13, 2021
@y0urself
Merge pull request #1765 from greenbone/mergify/bp/stable/pr-1764
1846370 
Flexible-docker-entrypoint (backport #1764)
y0urself added a commit that referenced this pull request Dec 13, 2021
@y0urself
Merge pull request #1766 from greenbone/mergify/bp/oldstable/pr-1764
5060565 
Flexible-docker-entrypoint (backport #1764)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0urself y0urself y0urself approved these changes

Assignees
No one assigned
Labels
backport-to-oldstable This pull request will be backported to the oldstable branch backport-to-stable This pull request will be backported to the stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @y0urself