Send an error message instead of the fallback report text to gsad. #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In gmp.c in function handle_get_system_reports (..): Adjusted an erroneous if-statement. In manage.c in function manage_system_report (..): Replaced the fallback report text by the appropriate error message.
jhelmold
added
the
backport-to-main
Added the ability to pass error message from the call of "get_osp_performance_string (..)" through to the gsad and further to GSA. Rebuilt the function manage_system_report (..) for that purpose.
…d/gvmd into performance_report_error_message
Added the documentation for the new parameter "error" of function get_osp_performance_string(..).
timopollmeier
requested changes
Sep 17, 2021
timopollmeier
approved these changes
Sep 17, 2021
jhelmold
removed
the
backport-to-main
|
The backport to main is done manually by PR #1745. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
In gmp.c in function handle_get_system_reports (..):
Adjusted an erroneous if-statement.
In manage.c in function manage_system_report (..):
Replaced the fallback report text by the appropriate
error message.
Why:
This change is part of a bug-fix.
How did you test it:
Tested by a special http-request.
Checklist: