Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resume task. #1679

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Fix resume task. #1679

merged 3 commits into from
Sep 14, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Sep 3, 2021 •
edited
Loading

What:
Fix resume task.

Jira: AP-1472

Why:
An already finished scan, can not be stopped, and must be deleted directly.
Also, there is a connection issue after asking for the scan status. As workaround
the connection is reset.

How did you test it:

  • Start a scan with many host.
  • Wait until some hosts finish and interrupt the scan changing the permissions in the openvas socket. The task will be set as interrupted.
  • Wait until ospd finished the scan successfully
  • Change the socket permissions again.
  • Resume the scan.
  • Check the logs (ospd, openvas and gvmd).

Checklist:

@jjnicola
Fix resume task.
f37d989 
An already finished scan, can not be stopped, and must be deleted directly.
Also, there is a connection issue after asking for the scan status. As workaround
the connection is reseted.
@jjnicola jjnicola requested a review from a team as a code owner September 3, 2021 13:34
@jjnicola jjnicola mentioned this pull request Sep 6, 2021
Open
@jjnicola jjnicola added the backport-to-main This pull request will be ported to the master branch label Sep 6, 2021
timopollmeier
timopollmeier reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look okay but there's a debug message that should be adjusted.

src/manage.c Outdated Show resolved Hide resolved
@timopollmeier timopollmeier merged commit ad0fc45 into greenbone:gvmd-21.04 Sep 14, 2021
@mergify mergify bot mentioned this pull request Sep 14, 2021
Merged
timopollmeier added a commit that referenced this pull request Sep 14, 2021
@timopollmeier
Merge pull request #1685 from greenbone/mergify/bp/master/pr-1679
5cc19f5 
Fix resume task. (backport #1679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
backport-to-main This pull request will be ported to the master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjnicola @timopollmeier