Use a saner default for GVM_FEED_LOCK_PATH #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GVM_FEED_LOCK_PATH is also used by the greenbone-feed-sync script. If gvmd is not running and not started by the systemd service file the /run/gvm directory (GVM_STATE_DIR) may not be available. Therefore use a saner default: /var/lib/gvm/feed-update.lock which corresponds to a similar lock file location in openvas scanner.
bjoernricks
added
backport-to-main
timopollmeier
approved these changes
Aug 19, 2021
This was referenced Aug 19, 2021
bjoernricks
added a commit
that referenced
this pull request
Aug 19, 2021
Use a saner default for GVM_FEED_LOCK_PATH (backport #1665)
bjoernricks
added a commit
that referenced
this pull request
Aug 19, 2021
Use a saner default for GVM_FEED_LOCK_PATH (backport #1665)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Use a saner default for GVM_FEED_LOCK_PATH
Why:
The GVM_FEED_LOCK_PATH is also used by the greenbone-feed-sync script.
If gvmd is not running and not started by the systemd service file the
/run/gvm directory (GVM_STATE_DIR) may not be available. Therefore use
a saner default: /var/lib/gvm/feed-update.lock which corresponds to a
similar lock file location in openvas scanner.
How did you test it:
Checklist: