Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better defaults for installation directories #1662

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Aug 4, 2021

What:

Changed defaults for installation locations

  • SYSCONFDIR is /etc by default now
  • LOCALSTATEDIR is /var by default now
  • GVM_RUN_DIR is /run/gvm by default now
  • OPENVAS_DEFAULT_SOCKET is /run/ospd/ospd-openvas.sock by default now
  • SYSTEMD_SERVICE_DIR is /lib/systemd/system by default now

Dropped gvmd.default file and use sane defaults in generated
gvmd.service file instead. Packagers should patch that file if it
doesn't fit instead of using the gvmd.default file.

Why:

Use the same sane defaults in all projects.

How did you test it:

Checklist:

Changed defaults for installation locations

* SYSCONFDIR is /etc by default now
* LOCALSTATEDIR is /var by default now
* GVM_RUN_DIR is /run/gvm by default now
* OPENVAS_DEFAULT_SOCKET is /run/ospd/ospd-openvas.sock by default now
* SYSTEMD_SERVICE_DIR is /lib/systemd/system by default now

Dropped gvmd.default file and use sane defaults in generated
gvmd.service file instead. Packagers should patch that file if it
doesn't fit instead of using the gvmd.default file.
@bjoernricks bjoernricks requested a review from a team as a code owner August 4, 2021 14:51
@bjoernricks bjoernricks added backport-to-stable This pull request will be backported to the stable branch backport-to-main This pull request will be ported to the master branch labels Aug 4, 2021
@bjoernricks bjoernricks merged commit 0df97cc into gvmd-20.08 Aug 4, 2021
@bjoernricks bjoernricks deleted the bricks/adjust-default-paths branch August 4, 2021 15:00
bjoernricks added a commit that referenced this pull request Aug 5, 2021
Use better defaults for installation directories (backport #1662)
bjoernricks added a commit that referenced this pull request Aug 5, 2021
Use better defaults for installation directories (backport #1662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch backport-to-stable This pull request will be backported to the stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants