Always quote C collation #1655
Merged
Always quote C collation #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems in contrast to other collations it is always required to quote the C collation. Otherwise creating the vts_verification_str raises an error when falling back to the C collation for DB with SQL_ASCII encoding. At least that's the behavior with Postgres 11 on Debian Buster.
bjoernricks
added
backport-to-main
jhelmold
approved these changes
Aug 2, 2021
This was referenced Aug 2, 2021
bjoernricks
added a commit
that referenced
this pull request
Aug 2, 2021
Always quote C collation (backport #1655)
bjoernricks
added a commit
that referenced
this pull request
Aug 2, 2021
Always quote C collation (backport #1655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Always quote C collation when creating the vts_verification_str function.
Why:
It seems in contrast to other collations it is always required to quote
the C collation. Otherwise creating the vts_verification_str raises an
error when falling back to the C collation for DB with SQL_ASCII
encoding. At least that's the behavior with Postgres 11 on Debian
Buster.
Closes AP-1619
How did you test it:
Tested on two systems. One with a DB using SQL_ASCII and one with UTF-8 encoding. Manually inserted the SQL for the function and tested the calculated digest.
Checklist: