Fix memory errors in modify_permission #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string "subject_where_old" was not freed when returning if check_permission_args failed. The string "name" was still used after being freed.
timopollmeier
added
backport-to-oldstable
bjoernricks
approved these changes
Jul 6, 2021
This was referenced Jul 6, 2021
bjoernricks
added a commit
that referenced
this pull request
Jul 6, 2021
Fix memory errors in modify_permission (backport #1613)
bjoernricks
added a commit
that referenced
this pull request
Jul 6, 2021
Fix memory errors in modify_permission (backport #1613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The string "subject_where_old" was not freed when returning if
check_permission_args failed.
The string "name" was still used after being freed.
Why:
How did you test it:
Checklist: