Add --optimize add-/cleanup-feed-permissions #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The add-feed-permissions option adds read permissions on the feed data objects for all roles defined in the "Feed Import Roles" setting if they do not exist. The cleanup-feed-permissions removes all role permissions on the feed data objects that do not match ones in the setting.
timopollmeier
added
backport-to-oldstable
If there are error responses from the create_permission_internal calls, they will now be handled by logging appropriate warning messages.
jhelmold
approved these changes
Jul 28, 2021
This was referenced Jul 28, 2021
timopollmeier
added a commit
that referenced
this pull request
Jul 28, 2021
Add --optimize add-/cleanup-feed-permissions (backport #1612)
timopollmeier
added a commit
that referenced
this pull request
Jul 28, 2021
Add --optimize add-/cleanup-feed-permissions (backport #1612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The add-feed-permissions option adds read permissions on the feed data
objects for all roles defined in the "Feed Import Roles" setting if they
do not exist.
The cleanup-feed-permissions removes all role permissions on the feed
data objects that do not match ones in the setting.
Why:
This addresses AP-1489 and AP-1387.
To have a simple way to ensure the permissions are set for the roles defined in the setting even if the feed data objects are already imported.
How did you test it:
By modifying the "Feed Import Roles" to add or remove roles and then running the new options.
Checklist: