Fix VTs hash check and add --dump-vt-verification #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The collation of the VTs and preferences is now set explicitly in the SQL used to get the string the VTs verification hash is calculated from to ensure the VTs and preferences are sorted consistently. The unhashed string is now also generated in a function and the command line option --dump-vt-verification has been added.
timopollmeier
force-pushed
the
vts-hash-fix
branch
from
c6708fd
to
fc2cf6f
Compare
timopollmeier
added
backport-to-oldstable
cfi-gb
suggested changes
Jul 6, 2021
bjoernricks
previously approved these changes
Jul 8, 2021
bjoernricks
approved these changes
Jul 8, 2021
timopollmeier
added a commit
that referenced
this pull request
Jul 8, 2021
bjoernricks
added a commit
that referenced
this pull request
Jul 8, 2021
Fix VTs hash check and add --dump-vt-verification (backport #1611)
|
@Mergifyio backport gvmd-21.04 |
|
Command
|
2 tasks
bjoernricks
added a commit
that referenced
this pull request
Jul 8, 2021
Fix VTs hash check and add --dump-vt-verification (backport #1611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The collation of the VTs and preferences is now set explicitly in the
SQL used to get the string the VTs verification hash is calculated from
to ensure the VTs and preferences are sorted consistently.
The unhashed string is now also generated in a function and the command
line option --dump-vt-verification has been added.
Why:
With the recent NVTs feed this caused the VTs verification to fail. See #1608.
How did you test it:
By running
gvmd --dump-vt-verification, redirecting the output to a file and comparing it to the output of a modified version of ospd-openvas that also dumps the non-hashed verification string to a file.I also ran gvmd --rebuild to check that warning about the mismatched hash disappeared.
Checklist: