Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test, if the ssh_elevate_credential is different from the ssh_credential. #1582

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented Jun 23, 2021

What:
In manage_sql.c:
Added a test, if the ssh_elevate_credential is different from
the ssh_credential in function "create_target(...)" and in
function "modify_target(...)".

In gmp.c:
Added the error messages for the case that the
ssh_elevate_credential is equal to the ssh_credential
in the function "gmp_xml_handle_end_element(...)" in
the create_target section and in the modify_target
section.

Why:
This is a part of a requirement.

How did you test it:

Checklist:

In manage_sql.c:
  Added a test if the ssh_elevate_credential is different from
  the ssh_credential in function "create_target(...)" and in
  function "modify_target(...)".

In gmp.c:
  Added the error messages for the case that the
  ssh_elevate_credential is equal to the ssh_credential
  in the function "gmp_xml_handle_end_element(...)" in
  the create_target section and in the modify_target
  section.
@jhelmold jhelmold added the backport-to-main This pull request will be ported to the master branch label Jun 23, 2021
@jhelmold jhelmold marked this pull request as ready for review June 23, 2021 13:52
@jhelmold jhelmold requested a review from a team as a code owner June 23, 2021 13:52
@timopollmeier timopollmeier merged commit 4590b8d into greenbone:gvmd-21.04 Jun 23, 2021
timopollmeier added a commit that referenced this pull request Jun 23, 2021
Added a test, if the ssh_elevate_credential is different from the ssh_credential. (backport #1582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants