Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new ssh elevate credential login data in OSP request #1539

Merged

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented May 31, 2021

What:
Appended the ssh elevate login data to the login
data of the target osp ssh credential in function
target_osp_ssh_credential() in manage.c.

Why:
A customer requested the new functionality.

How did you test it:

Checklist:

in manage.c: Appended the ssh elevate login data to the login
  data of the target osp ssh credential in function
  target_osp_ssh_credential().
in manage.c: Removed the erroneous type check for the
  ssh credential in function target_osp_ssh_credential()
  before appending ssh elevate credential login data to
  the ssh credential login data.
@jhelmold jhelmold marked this pull request as ready for review June 1, 2021 10:13
@jhelmold jhelmold requested a review from a team as a code owner June 1, 2021 10:13
src/manage.c Show resolved Hide resolved
src/manage.c Show resolved Hide resolved
in manage.c: Added the two missing free(osp_credential) calls in
  function target_osp_ssh_credential(..).
in manage.c: Changed the call of free(osp_credential) to
  osp_credential_free(osp_credential) in function
  target_osp_ssh_credential(..).
@jhelmold jhelmold added the backport-to-stable This pull request will be backported to the stable branch label Jun 2, 2021
@timopollmeier timopollmeier merged commit 775878c into greenbone:master Jun 2, 2021
@timopollmeier
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2021

Command refresh: success

Pull request refreshed

timopollmeier added a commit that referenced this pull request Jun 2, 2021
Include new ssh elevate credential login data in OSP request (backport #1539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-stable This pull request will be backported to the stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants