Fix erroneous freeing of ical timezone component #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icalendar component for a given timezone is now duplicated in icalendar_from_string because it the original one should not be freed. Doing so would cause double-free errors when modifying multiple schedules in the same process, e.g. in a single GMP connection.
timopollmeier
added
backport-to-oldstable
bjoernricks
approved these changes
May 24, 2021
This was referenced May 24, 2021
timopollmeier
added a commit
that referenced
this pull request
May 25, 2021
Fix erroneous freeing of ical timezone component (backport #1530)
timopollmeier
added a commit
that referenced
this pull request
May 25, 2021
Fix erroneous freeing of ical timezone component (backport #1530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The icalendar component for a given timezone is now duplicated in
icalendar_from_string because it the original one should not be freed.
Why:
Freeing the original component would cause double-free errors when
modifying multiple schedules in the same process, e.g. in a single
GMP connection.
How did you test it:
By creating several test schedules and modifying them using the script
added in greenbone/gvm-tools#445.
Checklist: