Rename the date column of reports to creation_time #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all relevant entries in manage_sql.c from date to creation_time. Changed the relevant entries for the creation of the database in manage_pg.c accordingly. Added a function for the necessary database changes in manage_migrators.c. Set the Databaseversion to 245.
timopollmeier
requested changes
May 17, 2021
creation_time AP-1343" issue. Removed 3 "CREATE OR REPLACE FUNCTION"-statements from manage_migrators.c, because they are redundant. Added "date" as an alias for "creation_time" to the corresponding line of the REPORT_ITERATOR_WHERE_COLUMNS columns and added it to the REPORT_ITERATOR_FILTER_COLUMNS columns. Did a few code format changes.
timopollmeier
requested changes
May 18, 2021
timopollmeier
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changed all relevant entries in manage_sql.c from date
to creation_time. Changed the relevant entries for the
creation of the database in manage_pg.c accordingly.
Added a function for the necessary database changes in
manage_migrators.c. Set the Databaseversion to 245.
Why:
Make report timestamps more consistent
How did you test it:
Checked scan runs, reports and filters
Checklist: