Sort missing severity as lowest value in GMP get #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a filter sorting by severity (or similar fields like cvss_base) is used in GMP get_... commands, missing values will be sorted as lower than any other value like 0.0 (log) or -1.0 (false positive).
timopollmeier
added
backport-to-stable
nichtsfrei
approved these changes
Apr 29, 2021
This was referenced Apr 29, 2021
timopollmeier
added a commit
that referenced
this pull request
May 3, 2021
timopollmeier
added a commit
that referenced
this pull request
May 3, 2021
Sort missing severity as lowest value in GMP get (backport #1508)
timopollmeier
added a commit
that referenced
this pull request
May 3, 2021
timopollmeier
added a commit
that referenced
this pull request
May 3, 2021
Sort missing severity as lowest value in GMP get (backport #1508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When a filter sorting by severity (or similar fields like cvss_base) is
used in GMP get_... commands, missing values will be sorted as lower
than any other value like 0.0 (log) or -1.0 (false positive).
Why:
When sorting SecInfo items by descending severity, those with known
high severity should be shown first. Items without severity info are often
deprecated, so they should be shown last.
How did you test it:
By sorting various SecInfo list pages by severity in GSA.
Checklist: