Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VT version handling for CVE & OVAL results #1496

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Apr 16, 2021

What:
The functions make_result and make_cve_result now add a timestamp
as nvt_version for CVE and OVAL results.

Why:
To have the VT version available in results more consistently.

How did you test it:
By running a CVE scan and checking the scan_nvt_version of the results.

Checklist:

The functions make_result and make_cve_result now add a timestamp
as nvt_version for CVE and OVAL results.
@timopollmeier timopollmeier marked this pull request as ready for review April 16, 2021 15:05
@timopollmeier timopollmeier requested a review from a team as a code owner April 16, 2021 15:05
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bjoernricks bjoernricks merged commit ca203c4 into greenbone:gvmd-21.04 Apr 19, 2021
@timopollmeier timopollmeier added the backport-to-main This pull request will be ported to the master branch label Apr 20, 2021
@timopollmeier
Copy link
Member Author

@Mergifyio backport master

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2021

Command backport master: success

Backports have been created

timopollmeier added a commit that referenced this pull request Apr 20, 2021
Improve VT version handling for CVE & OVAL results (backport #1496)
@timopollmeier timopollmeier deleted the cve-scan_nvt_version branch October 15, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants