Don't require report format for XML report #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to download the XML report without having to install the XML report format plugin which actually does nothing.
bjoernricks
added
the
backport-to-main
An additional check if get_reports_data->format_id is not NULL is added to the manage_send_report call because older clang versions do not recognize that this is covered by checking no_report_format.
Some of the lines recently added were too long, so they were reformatted to be shorter than 80 characters.
|
@timopollmeier thanks so much! More then I've ever expected. |
timopollmeier
added a commit
that referenced
this pull request
Mar 29, 2021
Don't require report format for XML report (bp #1466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Allow to download the XML report without having to install the XML
report format plugin which actually does nothing.
Why:
Remove GOS specific patch.
How did you test it:
This can be tested by deleting the XML report format and trying to access a report.
Without the patch the get_reports command will fail with a 404 error message:
"Failed to find report format 'a994b278-1f62-11e1-96ac-406186ea4fc5'" while
the XML can be fetched if no report format is selected.
Checklist: