Use pg-gvm extension for C PostgreSQL functions #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension functions written in C are no longer created directly in gvmd. Instead they will be handled by the extension "pg-gvm".
This extension is now required as the C functions are no longer created by gvmd.
The new extension library is custom-made for GVM and has to be installed separately from the PostgreSQL contrib extensions.
bjoernricks
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The extension functions written in C are no longer created directly in
gvmd. Instead they will be handled by the extension "pg-gvm".
Why:
The extension functions should be independent of gvmd and not be
overwritten by gvmd.
How did you test it:
By installing the extension, starting gvmd and then checking if the
extensions functions return the expected values instead of NULL from
the dummy functions.
Checklist: