Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto retry on scanner connection lost during a runnning task #1452

Merged
merged 11 commits into from
Mar 18, 2021
Merged

Add auto retry on scanner connection lost during a runnning task #1452

merged 11 commits into from
Mar 18, 2021

Conversation

jjnicola
Copy link
Member

What:
Add auto retry on scanner connection lost during a runnning task

Why:
During a running scan, gvmd set immediately the task as "stopped". This patch adds an option to retry to connect.

How did you test it:

  • Start a scan.
  • chmod the ospd-openvas socket with 400 permission.
  • check the logs

Checklist:

@jjnicola jjnicola requested a review from a team as a code owner March 17, 2021 15:41
timopollmeier
timopollmeier requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks okay aside from a few possible improvements to the documentation and two other small issues.

src/gvmd.c Outdated Show resolved Hide resolved
src/manage.c Outdated Show resolved Hide resolved
doc/gvmd.8.xml Outdated Show resolved Hide resolved
src/manage.c Outdated Show resolved Hide resolved
@jjnicola jjnicola added backport-to-stable This pull request will be backported to the stable branch backport-to-main This pull request will be ported to the master branch labels Mar 18, 2021
@timopollmeier timopollmeier merged commit 2931443 into greenbone:gvmd-20.08 Mar 18, 2021
This was referenced Mar 18, 2021
Merged
Merged
@cfi-gb cfi-gb mentioned this pull request Mar 19, 2021
Closed
@cfi-gb
Copy link
Member

cfi-gb commented Mar 19, 2021

@jjnicola @timopollmeier Could this also solve #1188 ?

timopollmeier added a commit that referenced this pull request Mar 22, 2021
@timopollmeier
Merge pull request #1454 from greenbone/mergify/bp/master/pr-1452
c998662 
Add auto retry on scanner connection lost during a runnning task (bp #1452)
timopollmeier added a commit that referenced this pull request Mar 22, 2021
@timopollmeier
Merge pull request #1455 from greenbone/mergify/bp/gvmd-21.04/pr-1452
31b5ced 
Add auto retry on scanner connection lost during a runnning task (bp #1452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
backport-to-main This pull request will be ported to the master branch backport-to-stable This pull request will be backported to the stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjnicola @cfi-gb @timopollmeier