Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send entire families to ospd-openvas using VT_GROUP #1384

Merged
merged 6 commits into from
Dec 23, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Dec 21, 2020

What:

When a config family is "growing" and includes all NVTs, then send the family to ospd-openvas using a single OSP VT_GROUP instead of many VT_SINGLEs.

Why:

  • Neater.
  • Saves some comm between gvmd and ospd.
  • Allows ospd-openvas to easily swap out whatever is going to produce the results (for example, using a new scanner instead of openvas).

How did you test it:

Log OSP in gvm-libs and check that the VT_GROUPs are sent.

+++ b/util/serverutils.c
@@ -751 +751 @@ gvm_server_vsendf (gnutls_session_t *session, const char *fmt, va_list ap)
-  return gvm_server_vsendf_internal (session, fmt, ap, 0);
+  return gvm_server_vsendf_internal (session, fmt, ap, 1);

Checklist:

@mattmundell mattmundell marked this pull request as ready for review December 21, 2020 21:38
@timopollmeier timopollmeier merged commit f316f3b into greenbone:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants