Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DB versions before CERT severity updates #1376

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Dec 11, 2020

What:

When rebuilding the SCAP or CERT database, check if the other one
has the correct version. If not, skip updating the CERT severity
scores.

Why:

This fixes an issue where the SCAP DB update during migration
does not work because the CERT DB is not migrated yet and therefore
incompatible.

How did you test it:

This was tested by running gvmd --migrate after the following:

  • Set SCAP and CERT DB version to 1 ok
  • Set SCAP DB version to 1, deleted CERT schema ok
  • Deleted SCAP schema, set CERT schema to 1 ok
  • Set SCAP DB version to 1, CERT DB version to 9999
  • Set SCAP DB version to 9999, CERT DB version to 1

After each step, the database was fully synced/rebuilt by letting gvmd run
normally until the regular update finished.
After setting a high version number, it was also set to 1 after the test run
and migrated.

Checklist:

When rebuilding the SCAP or CERT database, check if the other one
has the correct version. If not, skip updating the CERT severity
scores.
This fixes an issue where the SCAP DB update during migration
does not work because the CERT DB is not migrated yet and therefore
incompatible.
@timopollmeier timopollmeier marked this pull request as ready for review December 11, 2020 16:31
@mattmundell mattmundell merged commit e83266b into greenbone:master Dec 14, 2020
@timopollmeier timopollmeier deleted the secinfo-db-version-check branch October 15, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants